Remove popout styles #3747
Merged
Remove popout styles #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
the
service-badge
|
Good call, that case had slipped out of my mind! |
paulmelnikow
approved these changes
Jul 22, 2019
schloerke
added a commit
to rstudio/rstudio-shields
that referenced
this pull request
Aug 20, 2019
Undecided discussion from badges/shields#3635 rudely removed style=popout in badges/shields#3747
This was referenced Jun 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the popout styles, as discussed in #3635.
I've left the
logoPositioncode for now, we can delete in a few weeks when we're confident no one has complained about the popout removal and we go ahead with closing #3635 for good.