Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub manifest + dynamic JSON tests #2345

Closed
paulmelnikow opened this issue Nov 17, 2018 · 1 comment
Closed

Update GitHub manifest + dynamic JSON tests #2345

paulmelnikow opened this issue Nov 17, 2018 · 1 comment
Labels
good first issue New contributors, join in! keep-service-tests-green Related to fixing failing tests of the services service-badge Accepted and actionable changes, features, and bugs

Comments

@paulmelnikow
Copy link
Member

paulmelnikow commented Nov 17, 2018

Two of our GitHub tests depend on the contents of this repo's package.json, which has changed.

  10) Github
       Package name
         
	[ GET /package-json/n/badges/shields.json ]:

      AssertionError: expected { Object (name, value) } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "package name"
      -  "value": "shields.io"
      +  "value": "gh-badges"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  11) Github
       Package name - Custom label
         
	[ GET /package-json/name/badges/shields.json?label=Dev Name ]:

      AssertionError: expected { Object (name, value) } to deeply equal { Object (name, value) }
      + expected - actual

       {
         "name": "Dev Name"
      -  "value": "shields.io"
      +  "value": "gh-badges"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

Also these tests of the dynamic badge:

  14) User Defined JSON Source Data
       JSON from url
         
	[ GET .json?url=https://github.com/badges/shields/raw/master/package.json&query=$.name&style=_shields_test ]:

      AssertionError: expected { Object (colorB, name, ...) } to deeply equal { Object (name, value, ...) }
      + expected - actual

       {
         "colorB": "#4c1"
         "name": "custom badge"
      -  "value": "shields.io"
      +  "value": "gh-badges"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  15) User Defined JSON Source Data
       JSON from uri (support uri query paramater)
         
	[ GET .json?uri=https://github.com/badges/shields/raw/master/package.json&query=$.name&style=_shields_test ]:

      AssertionError: expected { Object (colorB, name, ...) } to deeply equal { Object (name, value, ...) }
      + expected - actual

       {
         "colorB": "#4c1"
         "name": "custom badge"
      -  "value": "shields.io"
      +  "value": "gh-badges"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

  16) User Defined JSON Source Data
       JSON from url | user color overrides default
         
	[ GET .json?url=https://github.com/badges/shields/raw/master/package.json&query=$.name&colorB=10ADED&style=_shields_test ]:

      AssertionError: expected { Object (colorB, name, ...) } to deeply equal { Object (name, value, ...) }
      + expected - actual

       {
         "colorB": "#10ADED"
         "name": "custom badge"
      -  "value": "shields.io"
      +  "value": "gh-badges"
       }
      
      at Object.pathMatch.matchJSON (node_modules/icedfrisby/lib/pathMatch.js:138:38)
      at _expect (node_modules/icedfrisby/lib/icedfrisby.js:583:10)
      at IcedFrisbyNock._invokeExpects (node_modules/icedfrisby/lib/icedfrisby.js:1261:26)
      at start (node_modules/icedfrisby/lib/icedfrisby.js:1244:12)
      at Request.runCallback [as _callback] (node_modules/icedfrisby/lib/icedfrisby.js:1131:16)
      at Request.self.callback (node_modules/request/request.js:185:22)
      at Request.<anonymous> (node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickDomainCallback (internal/process/next_tick.js:219:9)

Ref: #1359

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs labels Nov 17, 2018
@paulmelnikow paulmelnikow changed the title Update GitHub manifest tests Update GitHub manifest + dynamic JSON tests Nov 17, 2018
@paulmelnikow paulmelnikow added keep-service-tests-green Related to fixing failing tests of the services and removed bug Bugs in badges and the frontend labels Nov 17, 2018
@paulmelnikow
Copy link
Member Author

The first two of these were fixed in #2401, and fixes for the other two are pending in #2399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New contributors, join in! keep-service-tests-green Related to fixing failing tests of the services service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

1 participant