Fix failing service tests for [bintray npmlicense github crates] #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added
the
keep-service-tests-green
Generated by 🚫 dangerJS |
paulmelnikow
changed the title
paulmelnikow
changed the title
chris48s
reviewed
Nov 27, 2018
services/bintray/bintray.tester.js
Outdated
| module.exports = t | ||
|
|
||
| t.create('version') | ||
| .get('/asciidoctor/maven/asciidoctorj.json') | ||
| .expectJSONTypes( | ||
| Joi.object().keys({ | ||
| name: 'bintray', | ||
| value: isVPlusDottedVersionNClauses, | ||
| value: isSemver, |
There was a problem hiding this comment.
asciidoctorj has published versions which won't validate as SemVer e.g: 1.5.3.2, 1.5.3.1 so this will probably break again. See https://bintray.com/asciidoctor/maven/asciidoctorj How about isVPlusDottedVersionNClausesWithOptionalSuffix ?
chris48s
approved these changes
Nov 28, 2018
This was referenced Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2343 #2348 #2402
Ref: #2345 #1359