Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run service tests on commits to master #2388

Closed
paulmelnikow opened this issue Nov 24, 2018 · 1 comment
Closed

Don't run service tests on commits to master #2388

paulmelnikow opened this issue Nov 24, 2018 · 1 comment
Labels
developer-experience Dev tooling, test framework, and CI good first issue New contributors, join in!

Comments

@paulmelnikow
Copy link
Member

As mentioned at #2371 (comment) the simplification in #2371 did not work as intended, and has caused service tests to run on commits to master.

The Circle config should be updated so that services and services@node-latest don't run on the master branch.
@paulmelnikow paulmelnikow added good first issue New contributors, join in! developer-experience Dev tooling, test framework, and CI labels Nov 24, 2018
@chris48s chris48s mentioned this issue Nov 25, 2018
Merged
@paulmelnikow
Copy link
Member Author

Fixed in #2392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI good first issue New contributors, join in!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmelnikow