don't run service tests on master; test on [packagist] #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I think using a branch filter on the job would be more reliable (like we do with the |
chris48s
force-pushed
the
service-tests-on-master
branch
from
17b9149
to
f8620a5
Compare
paulmelnikow
approved these changes
Dec 3, 2018
|
Sorry; I had not noticed this was updated! |
|
It worked this time! https://circleci.com/workflow-run/e45cb66d-9a52-4f0a-a288-9eaab69b7c82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a sensible thing to do? I wonder if
CIRCLE_BRANCHany more reliably populated thanCI_PULL_REQUEST?Running tests on [packagist] just to check the tests still run on pull requests
refs #2388