Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle: Remove obsolete check #2371

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Circle: Remove obsolete check #2371

merged 2 commits into from
Nov 21, 2018

Conversation

paulmelnikow
Copy link
Member

As discussed at #2314.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Nov 19, 2018
@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

chris48s
chris48s approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for having a look at this. Hopefully this will ensure service tests run reliably 🤞

@paulmelnikow
Copy link
Member Author

I think the previous change did. Once there are no branch builds, Circle stops responding to push hooks. Then all the builds are triggered by PR hooks, so reliably are connected to their PRs.

@paulmelnikow paulmelnikow merged commit 5c577bf into master Nov 21, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the circle-prs branch November 21, 2018 22:07
@chris48s
Copy link
Member

Hmm.. this may have gone less well than planned.

I hadn't realised until we merged this but we are still trying to run the service tests when we merge to master.

screenshot at 2018-11-22 21-24-04

Is that expected with the current Circle CI settings?

@paulmelnikow
Copy link
Member Author

Ah, hrmmm. It might be. But we can fix it, by preventing those tasks from running on master via config (rather than “dynamically.”)

@paulmelnikow paulmelnikow mentioned this pull request Nov 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulmelnikow @shields-ci @chris48s