Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better modal popup #2496

Closed
8 of 12 tasks
paulmelnikow opened this issue Dec 10, 2018 · 3 comments
Closed
8 of 12 tasks

Better modal popup #2496

paulmelnikow opened this issue Dec 10, 2018 · 3 comments
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth frontend The React app and the infrastructure that supports it

Comments

@paulmelnikow
Copy link
Member

paulmelnikow commented Dec 10, 2018

I've been working on a major improvement to the modal popup which is basically an epic. I've been referencing it as #701, however #777, #1146, and #2427 are also included.

I'm opening this to track the feature in a way that gives a more transparency to the goalpost and the process.

Here's the behavior I'd like to implement:

  1. Show individual fields on the modal popup for each part of the URL path.
  2. Same for the query string.
  3. Pre-populate the fields with the example.
  4. Provide a Clear button and a Reset button.
  5. Add UI elements for the remaining badge options, e.g. logo.
  6. Provide a non-editable box (like the URL box now) which contains the full URL as it's built.
  7. Show the live preview whenever all the fields are filled in.

These are some of the technical milestones:

Superceding: #701 #777 #1146 #2427
Also ref: #1311

@paulmelnikow
Copy link
Member Author

Making progress with this!

screen shot 2018-12-13 at 7 21 47 pm

#2517 is blocking opening a PR, though it's not quite ready yet.

@paulmelnikow
Copy link
Member Author

The latest work on this is in #2554 / https://shields-staging-pr-2554.herokuapp.com.

This was referenced Jan 4, 2019
@paulmelnikow paulmelnikow added the blocker PRs and epics which block other work label Jan 4, 2019
@paulmelnikow
Copy link
Member Author

Let's track the remaining UI elements in #2867 and the remaining static previews in #1961.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth frontend The React app and the infrastructure that supports it
Projects
None yet
Development

No branches or pull requests

1 participant