Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some basic frontend tests #2490

Merged
merged 7 commits into from
Dec 10, 2018
Merged

Add some basic frontend tests #2490

merged 7 commits into from
Dec 10, 2018

Conversation

paulmelnikow
Copy link
Member

The frontend has a few tests in lib/ but not all of that is covered. The components are not covered at all. It's difficult to make changes to the frontend because you have to manually test that things haven't broken.

This PR uses Enzyme to add some shallow-rendering tests, which are essentially unit tests of the components.

This should pave the way for functional tests of the more complex components.

@paulmelnikow paulmelnikow added the frontend The React app and the infrastructure that supports it label Dec 9, 2018
@shields-ci
Copy link

shields-ci commented Dec 9, 2018 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against ca1581a

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2490 December 10, 2018 00:19 Inactive
@paulmelnikow paulmelnikow mentioned this pull request Dec 10, 2018
Closed
12 tasks
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2490 December 10, 2018 15:11 Inactive
chris48s
chris48s approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good place to start. I suspect we'll want to add more tests, but having the structure in place massively reduces the friction to adding them 👍

@paulmelnikow paulmelnikow merged commit a677c5b into master Dec 10, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the frontend-tests branch December 10, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
frontend The React app and the infrastructure that supports it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @chris48s