Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static examples to a few legacy services [travis david coveralls amo] #2407

Merged
merged 2 commits into from
Dec 1, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 27, 2018

It seems useful to accelerate #1961 even as the badge rewrites are still underway. This introduces a small amount of technical debt by hard-coding the static example, though continuing this work could allow us to eliminate the old ways of specifying examples. It seems like a decent tradeoff.

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Nov 27, 2018
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for amo but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for coveralls but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for david but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for travis but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm not too worried about the static example being hardcoded.

@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow mentioned this pull request Dec 10, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants