Simple Icons or custom Shields logos? #7684
Comments
|
|
|
|
|
|
|
|
|
|
|
Hi, I'm a maintainer of the simple-icons project. Do you have considered to accept an array of colors to fill closed or inferred closed subpaths, just in same the order that are defined them? I'm aware that you probably are not yet faimliarized with the internal of SVG |
|
"as they were deemed nicer" - while I appreciate that several of them might look nicer however I want to ask are they explicitly brand compliant? If not then are the ones maintained by the simply icons project brand compliant (@mondeja)? As a contributor to an open source project I know that is generally one of our biggest concerns. |
|
Thank you for the question @dtaivpp! It's certainly an important factor, but it's actually off topic for this particular issue which is trying to focus on one specific piece of the overall picture, so I'd ask it be deferred to somewhere else. The more holistic discussions, which include aspects like brand compliance, are being discussed elsewhere in the issues/discussions that were included in this issue's description (e.g. #6208). In short, brand compliance is part of the reason we have some of these custom logos to begin with (including Travis and Dependabot) as several were directly contributed to us by their respective owners. However, things change over time (Dependabot acquired by GitHub) and as we understand it, Travis employees/designers contributed to the Travis logo in the SI set too. As such, we're strictly trying to use this issue to get feedback on the user preference piece because if there's an overwhelming response from our users to keep our custom logos then it really nullifies the need for us to have to gauge other aspects like brand compliance with different icons. We're not trying gauge why any user might prefer an existing custom logo, nor are we asking anyone to rationalize their opinion. We're simply trying to poll our users to determine if there's a portion of our users that prefer the current experience so that we'll have that data point to feed into the broader discussion and decision. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi, I came to this thread cause the issue linked just above. So these are my 5 cents, for me was useful the fact that all icons would look consistently, same theme so to speak, I wanted to avoid a colourful table full of badges of different colours. Hope it helps, |
|
I propose this rules which should satisfy everyone:
If you want:
|
|
I open a pull request #8263 to my previous message:
|
|
I appreciate everyone's willingness to share their feedback! However, I want to gently remind everyone that this issue is simply a poll with one specific question. This is just one, small part of a broader set of discussions (the links to which can be found above), and here we're really trying to get a pulse on our users' binary subjective sentiment/preference between the respective icon pairs. We pulled out this one particular part of the broader discussion into a dedicated issue to make it easier to have a focused poll on that one topic. However, we'd really like to avoid bifurcating discussions or repeating/diving into those other topics and data points here in this poll. Anyone and everyone is always free to join participate in conversations in our community, but if you'd like to address something beyond the "I personally prefer the custom logo" or "I personally prefer the SimpleIcons logo" question of this poll, then that feedback would be best directed elsewhere, such as #6208 edit: typo fixes |
|
We've just merged and deployed #8263 which implements a compromise for this: In cases where we hold a custom (multi-coloured) logo, that one will be used in preference to SimpleIcons.
This does represent a behaviour change for any existing badges using a custom logo with |
|
In light of the above compromise and given the survey results, I'll go ahead and close this for the time being. |
|
Worth noting that the Gitlab and Paypal logos have since then been updated on the Simple-Icons side (simple-icons/simple-icons#7364 and simple-icons/simple-icons#9579), and should be more legible and appealing when used on a Shields.io badge. Above tables do not reflect the latest status. |
As you may already be aware, Shields.io supports adding logos to badges by leveraging the Simple-Icons project. However, it still maintains a small set of custom icons, which can be found in this directory. We decided to keep these as they were deemed nicer than the Simple Icons versions at the time (see #2510 for the full history).
In #6208, we've been discussing whether we should get rid of the remaining icons, and fully rely on Simple Icons. Reasons for considering a removal include the following:
logoColorquery parameter. Users occasionally open issues about this (e.g. logoColor is ignored for specific icons #6208, 'Telegram' logo does not respect logoColor value #7576).logoparameter with a base64-encoded image.However:
The main point of debate is aesthetics, and it's a highly subjective matter. If you have badges that use one of our custom logos listed below, we're keen on hearing what you think! For each logo that I'll be posting in follow up messages, either add 🎉 if you prefer the custom Shields.io version, a 🚀 if you prefer the Simple Icons version, or 👀 if you're undecided. If you don't use or intend on ever using some of the listed logos, you can simply skip voting on those.
A logo with a majority of votes in favour of the Simple-Icons version will be considered for removal from the Shields.io codebase. If there is a significant drive towards Simple-Icons for several logos, we'll discuss whether visual concerns for the remaining ones outweigh the gains that could be achieved by a full removal. We'll examine the votes carefully to inform our decisions, but the maintainer team will be responsible for making the final call.
The text was updated successfully, but these errors were encountered: