-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace the outdated Telegram logo with the newest #7831
Conversation
Thank you for the pull request. There's some relevant information that I've shared below for reference, but I'm also curious if you could please elaborate with more detail on your proposed changes. Are you associated with the Telegram project? Do they have explicit published logo guidelines? |
I’m not associated with Telegram. I don’t know about their guidelines. Although, it is clear for everyone that the logo you are currently using is outdated, and no official client use that anymore. You could see: |
wait what how did I approve it |
@Oren-Lindsey Good thing you did! |
Telegram officially links the logos to be used: https://telegram.org/tour/screenshots#logos The zip contains the current and an old logo. It also states:
|
Thank you, @EdJoPaTo! |
While we're maintaining custom logos, we should make sure the ones we are using are current, even if we may end up switching them out for SimpleIcons. @roj1512 - has this logo been minified with svgo? Instructions on how to do that are in our guidance for logos: https://github.com/badges/shields/blob/master/doc/logos.md#contributing-logos |
@chris48s You could also add a parameter to force the logo to be from simpleicons. |
@chris48s How is it now? |
Thanks, but I think perhaps it may not be clear why we put this on pause. To summarize from the linked issue, we don't really want to have to maintain custom logos, and defer as much as possible to simple icons. We have a couple remaining custom logos, including telegram, which some, perhaps most, of us would like to get rid of altogether. We opted to hold off on this because there was hope that we'd come to a fairly quick resolution around that question of whether we'd drop all of our remaining custom logos, and with that in mind we certainly wouldn't want to extend our own API surface with additional features or parameters in order to account for custom vs. SI logos. That being said, it's clear the question around custom logos is going to linger for quite some time, so I agree with Chris that we may as well go ahead and update this one. |
No description provided.