-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deno shield #197
Add Deno shield #197
Conversation
If its style not matching with the other badges is a problem, we can modify the styles of the shieldsio badges. The style of the Deno shield is not modifiable. |
Yes, please align the designs before we merge this. |
@KnorpelSenf How are they looking now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Good idea :)
In fact, |
This comment was marked as off-topic.
This comment was marked as off-topic.
@KnorpelSenf If you prefer, we can remove the version part on the npm badge and do all of the work with shieldsio. |
I think it makes a lot of sense to have the same version on both shields. That way, it's very clear how we publish the identical versions for both runtimes. |
That way you should use the Deno shield. Because there won't be a way to add the version to a manually made shieldsio badge, and it won't look cool if we have the version on the npm badge, but not on the Deno one. |
Ah right, good point, I did not think about that. In that case, we can leave things as they are now. |
Alternatively… isnt shields.io open source? 😏 |
You want to fork and add the feature we need? |
@EdJoPaTo Does that mean you will host your instance with this feature, or do you mean to PR this feature? They don’t accept PRs easily. Reference: badges/shields#7831 |
It seems like there is progress on the linked PQ now. |
Yes, happily. |
@roj1512 this PQ modified the section controlled by all-contributors. The styling will be overwritten whenever a new contributor gets listed in the README. Should we maybe switch to the automatically generated badge the is described in all-contributors/all-contributors#406? |
- This maintains our custom styles and makes the style of the badge for All Contributors consistent with the others. - Related: #197 (comment)
No description provided.