Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate.io uses poorly designed custom badges based on Shields #83

Closed
olivierlacan opened this issue Nov 22, 2013 · 5 comments
Closed

crate.io uses poorly designed custom badges based on Shields #83

olivierlacan opened this issue Nov 22, 2013 · 5 comments
Assignees
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@olivierlacan
Copy link
Member

I reached out them here.

@ghost ghost assigned olivierlacan Nov 22, 2013
@kura
Copy link

kura commented Dec 23, 2013

@olivierlacan I reached out to this project to get help generating the images when pypip.in first went live but got no luck.

This weekend I switched to use the shields.io service and found an issue with it when dealing with versions.

For example this image works fine

1.8.0

http://img.shields.io/version/1.8.0.png?color=green

But this one does not

1.11

http://img.shields.io/version/1.11.png?color=green

While trying to find the source code of shields.io (which I couldn't find by the way) I stumbled on the code for http://b.repl.ca/ and bypassed this issue by using that for generation... Which may or may not be naughty. Sorry if it is.

@nathany
Copy link
Contributor

nathany commented Dec 23, 2013

@kura we are planning to replace img.shields.io with the code used for http://b.repl.ca/ So no worries, you're still on the nice list. Merry Christmas!

@kura
Copy link

kura commented Dec 24, 2013

@nathany thanks. Can you maybe do a pull request against https://github.com/kura/pypipins/blob/master/pins/pins.py and change the SHIELD_URL when you officially change the API please?

@nathany
Copy link
Contributor

nathany commented Dec 24, 2013

@jbowes We should be sure to keep b.repl.ca running with the same API until everyone has a chance to switch to img.shields.io.

@olivierlacan
Copy link
Member Author

Resolved!

image

@paulmelnikow paulmelnikow added question Support questions, usage questions, unconfirmed bugs, discussions, ideas and removed needs-upstream-help Not actionable without help from a service provider labels Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

4 participants