Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Team #96

Closed
nathany opened this issue Jan 8, 2014 · 19 comments
Closed

The Team #96

nathany opened this issue Jan 8, 2014 · 19 comments
Assignees
Milestone

Comments

@nathany
Copy link
Contributor

nathany commented Jan 8, 2014

It's great to see the implementations come together. Now let's formalize the core team.

For each area, I'd like to know who is willing to commit time, and one person to be responsible for ensuring stuff gets done (team lead).

Here are the areas I can think of:

  • gh-badges implementation (Node.js). We'll set up a GitHub team for those who commit to contributing, doing code reviews, etc.
  • Badge visual design spec
  • web API design spec (including researching existing APIs and public facing documentation) web API design #100
  • Web site content, including history, mission, etc.
  • Web site and logo design
  • Hosting/Devops
  • Business administration
  • Static SVG cross-browser testing (Retina)
  • Srcset cross-browser testing @2x.png (Retina)

So step up or nominate someone. Use this thread to invite others to the project.

@nathany
Copy link
Contributor Author

nathany commented Jan 9, 2014

@Mikulas Thanks again for letting us use your organization. How would you like to be involved in the project going forward?

@nathany
Copy link
Contributor Author

nathany commented Jan 9, 2014

Guess I'll go first. In addition to the work I've been to help get us organized and on track, I commit to:

@sqs
Copy link

sqs commented Jan 9, 2014

Is 'API Design Spec' the design of the HTTP API, or the underlying node.js library? (Assuming the former.)

@nathany
Copy link
Contributor Author

nathany commented Jan 9, 2014

@sqs I intended the former. Here's an issue to discuss it further. #100

@Mikulas
Copy link

Mikulas commented Jan 9, 2014

@nathany While I understand why you've chosen to start working from gh-badges, it just seems to me you are arriving at the same problems I already solved in my implementation. That's no jealousy speaking or whatever, it just seems wasteful. My opinion notwithstanding, I will continue researching the optimal method for loading embedded fonts in svg, possibly with font subsetting if I find no magical all-browser-supported hack so your current svg template can benefit from it while retaining the (uneccessary) small file size.

@espadrine
Copy link
Member

@Mikulas That's really great!

I'd love you to document your findings. If you find a better tradeoff than what gh-badges has to offer, it can probably benefit from it as well.

Currently, the big issue is loading. I'd assume it may be possible to have a fast-track loading for ASCII only, and a (or multiple wrt regionalization) slow-track(s) for unicode characters.

Btw, you only need to include one font — I noticed you include several. Having a local("Open Sans") is equally meaningless, since the base64 TTF would work everywhere..

@Mikulas
Copy link

Mikulas commented Jan 9, 2014

@espadrine I include one font, but in two different formats for compatibility. One works in mobile Safari and the other is for early firefox if I recall correctly - including only one breaks the other. Will document this later on. local("Open Sans") is there because I believe it could be faster for the browser to address a font it could have in memory then parsing the base64 encoded file. It depends on the actual css parser implementation, I should probably benchmark it. But hey, it's just a few bytes anyway :)

Also what http://caniuse.com/ttf is about is including the font in a website. Including the font in a svg is major problem and it's not supported well in most browsers. Base64 encoded truetype does NOT work in SVG in all browsers. I will create samples and shots from browserstack.com soon for you guys to check and for future reference.

PS: browsers render raw svg differently than embedded svg inside a web page (ig example.com/test.svg vs example.com that has test.svg in an image tag). Firefox loads the font on one but not the other etc.

@nathany
Copy link
Contributor Author

nathany commented Jan 9, 2014

Thanks @Mikulas.

While I appreciate the enthusiasm, let's try to keep this thread to a discussion of what people are committing to, and discussion about the font in #97. Think of your future self when trying to scan through what was said. Cool?

@nathany
Copy link
Contributor Author

nathany commented Jan 9, 2014

While I understand why you've chosen to start working from gh-badges, it just seems to me you are arriving at the same problems I already solved in my implementation. That's no jealousy speaking or whatever, it just seems wasteful. - #96 (comment)

I don't consider rewriting an implementation wasteful, especially at this early state:

In most [software] projects, the first system is barely usable. It may be too slow, too big, awkward to use, or all three. There is no alternative but to start again, smarting but smarter, and build a redesigned version in which these problems are solved.... Hence, plan to throw one away; you will, anyhow. - Fred Brooks

What's important to me is that we have the team of people that built these implementations and the _enthusiasm_ to continue building a production-ready version. Consider the font research #97 (comment) you've done. I'm sure that took a fair bit of time, but to take that and apply it to another implementation is now just a few lines of code.

That said, if people would like to do a more formal evaluation of the existing implementations, I'll create a new issue with some criteria to get us started. @Mikulas Fyi, I didn't see the PHP/server code in your repo.

@chadwhitacre
Copy link
Contributor

@nathany I'm willing to work on:

  • Web site content, including history, mission, etc.
  • Business administration

I'll help with Hosting/DevOps as I'm needed for that. Ideally we can hand that off to others once a few things stabilize (SSL, GH pages, ...).

I'm also closely watching the branding/logo ticket (#92). I'm watching the rest of the tickets, too. :-)

@seanlinsley
Copy link
Contributor

I'd usually sign up for Hosting/Devops since it's "easy" for me, but I'd be willing to take on whatever no one else will.

@nathany
Copy link
Contributor Author

nathany commented Jan 10, 2014

@seanlinsley That'd be great. Dev Ops is not my cup of tea.

@nathany
Copy link
Contributor Author

nathany commented Jan 10, 2014

I will be firming up the GitHub permissions over the weekend. I don't think we need everyone to be an owner (mostly for billing info, which doesn't apply to us).

Also, @whit537 can you chime in with regards to: https://www.gittip.com/Shields.io/

@nathany
Copy link
Contributor Author

nathany commented Jan 12, 2014

@whit537 If @espadrine is stepping up as lead developer, we should really add him to the team at https://www.gittip.com/Shields.io/, yes? How does one invite him?

@nathany
Copy link
Contributor Author

nathany commented Jan 12, 2014

I setup more fine grained permissions (docs) for teams under badges. If anyone is unhappy with what access they have, let me know.

@chadwhitacre
Copy link
Contributor

@nathany Control of the Gittip account is via the Twitter account, so we should have @olivierlacan share Twitter creds with you.

@nathany
Copy link
Contributor Author

nathany commented Jan 15, 2014

Sure. Or @olivierlacan can just add @espadrine to the team on Gittip. :-)

@chadwhitacre
Copy link
Contributor

@nathany You're playing a much more direct part in the day-to-day management of this project than @olivierlacan is able to at this point. I think you should have access to Twitter and Gittip.

@chadwhitacre
Copy link
Contributor

In my experience "formal team" and "open source" don't go together. The core team will emerge organically based on who has interest and time. Closing to clear out the Getting Organized milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants