-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [Docker] support for loong64 arch #10241
Conversation
Wow, these tests were pretty stable and were working fine not so long ago (#9934), but we've now got a bunch a failures. Maybe best to take a look in a follow up? |
I overlooked the test failures, though this change is correct
The test failures are unrelated IMO, so I agree and I'd be fine giving this the 👍 to go ahead and fix #10224, and then address the failing tests separately. Let me know if you'd like me to re-approve or if you change your mind and decide to try to fix the tests here |
I've fixed one of the tests to use a better example. The other ones seems to be getting 401 responses, they're all Docker Cloud examples. Our Docker badges support optional auth: shields/services/docker/docker-automated.service.js Lines 19 to 25 in 0360ba3
As far as I can tell, we only ever configured |
So 2 things:
The docker credentials in the repo secrets (not prefixed with Looking at it, I think this is not just the service tests. I think the DockerCloud badges are just completely broken - with or without credentials. I think this is due to an upstream change. I'm also happy to punt this to another issue as it is unconnected to this PR, but does want fixing. Related: #9563 btw, I've been waiting for this fix to land for a looooong time |
Fixes #10224.