Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [Docker] support for loong64 arch #10241

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jun 8, 2024

Fixes #10224.

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 5f66c40

@PyvesB
Copy link
Member Author

PyvesB commented Jun 8, 2024

Wow, these tests were pretty stable and were working fine not so long ago (#9934), but we've now got a bunch a failures. Maybe best to take a look in a follow up?

calebcartwright
calebcartwright previously approved these changes Jun 8, 2024
@calebcartwright calebcartwright dismissed their stale review June 8, 2024 19:46

I overlooked the test failures, though this change is correct

@calebcartwright
Copy link
Member

The test failures are unrelated IMO, so I agree and I'd be fine giving this the 👍 to go ahead and fix #10224, and then address the failing tests separately.

Let me know if you'd like me to re-approve or if you change your mind and decide to try to fix the tests here

@PyvesB
Copy link
Member Author

PyvesB commented Jun 9, 2024

I've fixed one of the tests to use a better example.

The other ones seems to be getting 401 responses, they're all Docker Cloud examples. Our Docker badges support optional auth:

userKey: 'dockerhub_username',
passKey: 'dockerhub_pat',
authorizedOrigins: [
'https://hub.docker.com',
'https://registry.hub.docker.com',
],
isRequired: false,

As far as I can tell, we only ever configured dockerhub_username but not dockerhub_pat in our GitHub actions configuration. I'm wondering whether Docker Cloud started requiring auth for some of its API endpoints, or whether the project we're testing against, pavics/magpie, moved to being a private one. @chris48s you're much more familiar with the service and reworked auth recently, do you have any insights?

@chris48s
Copy link
Member

chris48s commented Jun 9, 2024

So 2 things:

  1. When you run service tests from a fork, we don't pass any secrets so on this PR (submitted from your fork) there are no credentials being used
  2. Even when submit a PR from a local branch on this repo, the vars we pass are:
    github-token: '${{ secrets.GH_PAT }}'
    librariesio-tokens: '${{ secrets.SERVICETESTS_LIBRARIESIO_TOKENS }}'
    obs-user: '${{ secrets.SERVICETESTS_OBS_USER }}'
    obs-pass: '${{ secrets.SERVICETESTS_OBS_PASS }}'
    pepy-key: '${{ secrets.SERVICETESTS_PEPY_KEY }}'
    sl-insight-user-uuid: '${{ secrets.SERVICETESTS_SL_INSIGHT_USER_UUID }}'
    sl-insight-api-token: '${{ secrets.SERVICETESTS_SL_INSIGHT_API_TOKEN }}'
    twitch-client-id: '${{ secrets.SERVICETESTS_TWITCH_CLIENT_ID }}'
    twitch-client-secret: '${{ secrets.SERVICETESTS_TWITCH_CLIENT_SECRET }}'
    wheelmap-token: '${{ secrets.SERVICETESTS_WHEELMAP_TOKEN }}'
    youtube-api-key: '${{ secrets.SERVICETESTS_YOUTUBE_API_KEY }}'
    dockerhub username (or PAT) isn't one of the things we set.

The docker credentials in the repo secrets (not prefixed with SERVICETESTS_) are used for pushing the images we build to DockerHub.

Looking at it, I think this is not just the service tests. I think the DockerCloud badges are just completely broken - with or without credentials. I think this is due to an upstream change. I'm also happy to punt this to another issue as it is unconnected to this PR, but does want fixing. Related: #9563

btw, I've been waiting for this fix to land for a looooong time :trollface:

@PyvesB PyvesB merged commit 6be6c1d into badges:master Jun 9, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Image Size arch error
3 participants