Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate some services from examples to openApi part 47; affects [docker] #9934

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

chris48s
Copy link
Member

Refs #9285

I'm going to cautiously say: I think this is the last one.

Once all the outstanding related PRs are merged (including #9932 ) I think that should be every service moved over to using openApi, unless I missed a spot 🤞 and I can:

  • Start on the cleanup necessary to remove all the compatibility stuff that allowed examples and openApi to exist side-by-side
  • Revisit upgrade to docusaurus 3 #9820 (it was too hard to work on with this still in flight)

Hopefully.

@chris48s chris48s added service-badge Accepted and actionable changes, features, and bugs documentation Developer and end-user documentation labels Jan 29, 2024
static examples = [
{
title: 'Docker Cloud Automated build',
documentation: '<p>For the new Docker Hub (https://cloud.docker.com)</p>',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to ignore #9563 here and just move what we've got. But Docker Cloud is definitely not "the new Docker Hub" 😄

Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against b80dfd2

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍🏻

@chris48s chris48s added this pull request to the merge queue Feb 11, 2024
Merged via the queue into badges:master with commit 79bd5f3 Feb 11, 2024
23 checks passed
@chris48s chris48s deleted the 9285-part47 branch February 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants