upgrade to docusaurus 3 #9820
Merged
upgrade to docusaurus 3 #9820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@docusaurus/core@2.4.3, npm/@mdx-js/react@1.6.22, npm/docusaurus-preset-openapi@0.6.4 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Dec 22, 2023
in docusaurus 3 this is now a hard error, not just a warning
chris48s
force-pushed
the
9816-docusaurus
branch
from
d6accc5
to
f5df52a
Compare
fixes performing the 'execute' action when pressing enter
|
I'll keep this updated as we merge new stuff, but this one would be really useful to get a review on sooner rather than later as it touches a lot of things. |
|
🚀 Updated review app: https://pr-9820-badges-shields.fly.dev |
|
🚀 Updated review app: https://pr-9820-badges-shields.fly.dev |
|
I've decided I'm just going to go rogue and merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9816
This PR upgrades
and I've made all the necessary formatting changes to all of the documentation to make MDXv3 happy, display everything sensibly and fix all the
validateDOMNestingwarnings (mostly<p> cannot appear as a descendant of <p>and<a> cannot appear as a descendant of <a>warnings).This PR is changing a lot at once, but I have split things out into commits so the functional changes are easy to separate from the minor alterations to documentation markup.
Relevant background reading:
One of the things that docusaurus 3 should allow us to do is migrate the frontend from CJS to ESM, but I've decided not to do that here because we don't have to do it in order to upgrade and the PR is already big. I'm going to punt that change to a follow up issue.