[GitHub] Fix Travis-CI GitHub rate limiting #1094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis-CI Enviroment variable `github_token` will need to be set.
|
Thanks for this. I'd rather not add one-off logic to deal with our internal uses. While it'd be nice to provide a way to load secrets from the environment (rather than the filesystem) I'd want to do that in a holistic way. I opened #1095 which is an alternate approach. See what you think. |
unassigned githubUserTokens -> process.env.github_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #979 limit on GitHub request.
Travis-CI Environment variable
github_tokenwill need to be set for this to work though.