Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Github] rate limits in CI #1095

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Fix [Github] rate limits in CI #1095

merged 2 commits into from
Sep 28, 2017

Conversation

paulmelnikow
Copy link
Member

Alternate to #1094 for fixing #979.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Sep 25, 2017
@paulmelnikow paulmelnikow changed the title Fix Github rate limits in CI Fix [Github] rate limits in CI Sep 26, 2017
@RedSparr0w
Copy link
Member

RedSparr0w commented Sep 26, 2017

Looks like a good approach,
From the looks of github-auth.js, the keys are stored in /private/github-user-tokens.json as something along the lines of:

{
  "data" : [
    "yourkeyhere",
    "asecondkeyhere",
    "athirdkeyifneeded"
  ]
}

although i may be wrong as i haven't actually tested it all out

edit: never mind, looks like you can store it in either file, i missed this line,
Makes sense to just store it in /private/secret.json as only 1 key should be needed.

@paulmelnikow
Copy link
Member Author

Cool. It's working, by the way! The CI build on this PR is running all the Github tests. I'm eager to get this fixed. I guess I was hoping for a better solution than this, though clearly I should have just done this a long time ago.

@Daniel15, would you mind reviewing this?

@Daniel15
Copy link
Member

Looks great!

@Daniel15 Daniel15 merged commit 6287c65 into badges:master Sep 28, 2017
@paulmelnikow paulmelnikow deleted the github-auth-ci branch September 28, 2017 00:49
@paulmelnikow
Copy link
Member Author

Thanks @Daniel15!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants