Redirect the root only when configured #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added
developer-experience
|
Companion PR: badges/ServerScript#1. |
platan
reviewed
Nov 16, 2017
doc/self-hosting.md
Outdated
| Set the `FRONTEND_REDIRECT_URI` environment variable: | ||
|
|
||
| ```sh | ||
| FRONTEND_REDIRECT_URI=http://my-custom-shields.s3.amazonaws.com/ |
There was a problem hiding this comment.
In this file we have FRONTEND_REDIRECT_URI, but in lib/server-config.js, shields.example.env and badges/ServerScript#1 there is FRONTEND_REDIRECT_URL (URL instead of URI).
But it looks and works good for me.
There was a problem hiding this comment.
Good catch, thank you!
espadrine
pushed a commit
to badges/ServerScript
that referenced
this pull request
Dec 3, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #1260 for #1259.