Allow configuring allowed CORS origins for suggest #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support single-server testing and a local dev server (like Next) that is on a different port from the shields server - Refactor config schema
paulmelnikow
added
the
frontend
|
Companion PR: badges/ServerScript#2 |
|
Code looks good for me. I'm going to run it and test it tomorrow. |
platan
reviewed
Nov 23, 2017
| ``` | ||
|
|
||
| If you want to use server suggestions, you should also set `ALLOWED_ORIGIN`: |
There was a problem hiding this comment.
In line 20 in this file, there is an info that one should build frontend using BASE_URL=https://your-server.example.com npm run build:production
build:production runs make footer-production-transform, which sets img.shields.io as a suggestions server (var origin = 'https://img.shields.io'; in index.html). Requests from locally build frontend will go to img.shields.io.
There was a problem hiding this comment.
Thanks for noticing that. It should be fixed as part of #1273, which gets rid of the makefile transform and ships the suggestions server through the bundle.
|
Thanks for the careful read + review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the suggestions work locally in #1273.