Merge pull request grpc#1343 from Patrick-Remy/patch/grpc-native-type…

…script-definition-complience grpc-js: adjust ts definitions to equal native-core
badsyntax · Apr 9, 2020 · 9485062 · 9485062
2 parents 4823d97 + c622039
commit 9485062
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/grpc-js/src/index.ts b/packages/grpc-js/src/index.ts
@@ -35,6 +35,7 @@ import {
   Deserialize,
   loadPackageDefinition,
   makeClientConstructor,
+  MethodDefinition,
   Serialize,
   ServiceDefinition,
 } from './make-client';
@@ -230,6 +231,7 @@ export {
   ClientWritableStream,
   ClientDuplexStream,
   CallOptions,
+  MethodDefinition,
   StatusObject,
   ServiceError,
   ServerUnaryCall,

diff --git a/packages/grpc-js/src/make-client.ts b/packages/grpc-js/src/make-client.ts
@@ -18,6 +18,7 @@
 import { ChannelCredentials } from './channel-credentials';
 import { ChannelOptions } from './channel-options';
 import { Client } from './client';
+import { UntypedServiceImplementation } from './server';
 
 export interface Serialize<T> {
   (value: T): Buffer;
@@ -49,9 +50,9 @@ export interface MethodDefinition<RequestType, ResponseType>
   extends ClientMethodDefinition<RequestType, ResponseType>,
     ServerMethodDefinition<RequestType, ResponseType> {}
 
-export interface ServiceDefinition {
+export type ServiceDefinition<ImplementationType = UntypedServiceImplementation> = {
   // tslint:disable-next-line no-any
-  [index: string]: MethodDefinition<any, any>;
+  readonly [index in keyof ImplementationType]: MethodDefinition<any, any>;
 }
 
 export interface ProtobufTypeDefinition {