better handling of exceptions from AWS/S3 #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbwlng
reviewed
May 22, 2024
joshbwlng
reviewed
May 22, 2024
.. otherwise when processing device types and hitting private DTs, openBalena generates lots of noise/exceptions in the logs * also correct systemd unit Co-authored-by: Josh Bowling <45343541+joshbwlng@users.noreply.github.com> change-type: patch
joshbwlng
reviewed
May 23, 2024
| @@ -2,6 +2,7 @@ | |||
| Description=open-balena-api | |||
| Requires=confd.service | |||
| After=confd.service | |||
| StartLimitIntervalSec=0 | |||
There was a problem hiding this comment.
Just leaving a note here about the change. Apparently StartLimitIntervalSec is in fact a unit option and not a service option:
joshbwlng
approved these changes
May 23, 2024
thgreasi
reviewed
May 24, 2024
| return await req.promise(); | ||
| } catch (err) { | ||
| // catch errors for private device types when running unauthenticated | ||
| logUnauthenticatedWarning(s3Client, s3Path, err); |
There was a problem hiding this comment.
@ab77 This atm silences ALL errors. Shouldn't we re-throw the error when this is a different type of error that logUnauthenticatedWarning didn't handle?
There was a problem hiding this comment.
Fair point, we should make sure other errors aren't ignored
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. required (ideally) by balena-io/open-balena#141
We have two contracts repos, one is private and the other public.
So open-balena-api can't access the private repo, to check which device types are private, but it can enumerate the entire images bucket, which has with public
ListACL enabled. Since it can see private devices in the enumerated list, the API will try to access various assets, but will get back a 403 from S3 API, since the objects themselves don't have public-read enabled. This behaviour produces a lot of exceptions in the API logs and this is what this PR attempts to make better.A more complete solution would probably require rethinking private/public DT handling in open-balena-api vs. balena-api.
.. in any case, events now reflected in the logs as follows: