Update s3 error handling and logs #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbwlng
force-pushed
the
joshbwlng/s3-errors
branch
2 times, most recently
from
3700666
to
eb7d16f
Compare
thgreasi
reviewed
Jun 10, 2024
| @@ -57,19 +57,20 @@ function createS3Client() { | |||
|
|
|||
| const s3Client = createS3Client(); | |||
|
|
|||
| function logUnauthenticatedWarning( | |||
| function isUnauthenticated( | |||
There was a problem hiding this comment.
How about v ?
function isUnauthenticatedError(
clientS3: UnauthenticatedS3Facade | AWSWrapper.AWS.S3,
err: Error, // or any ?
): boolean {
auto-merge was automatically disabled
June 10, 2024 09:01
Pull request was converted to draft
thgreasi
approved these changes
Jun 10, 2024
Change-type: patch
joshbwlng
force-pushed
the
joshbwlng/s3-errors
branch
from
eb7d16f
to
fc5f070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
A continuation of #1643 splitting the logic up a bit and throwing more often (avoid swallowing errors)