Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native): add expo compatibility for android #56

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

Almouro
Copy link
Member

@Almouro Almouro commented Jun 14, 2022

See expo/expo#17852 with more details on why this is needed

Needed for #40

@Almouro Almouro marked this pull request as ready for review June 15, 2022 08:33
Base automatically changed from upgrade-example to master June 15, 2022 09:08
@Almouro Almouro force-pushed the android-expo-compatibility branch from 7838441 to d2ed444 Compare June 15, 2022 09:09
Copy link

@nicolashaan nicolashaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Almouro Almouro merged commit 647489a into master Jun 20, 2022
@Almouro Almouro deleted the android-expo-compatibility branch June 20, 2022 09:42
Almouro added a commit that referenced this pull request Nov 5, 2022
Almouro added a commit that referenced this pull request Mar 13, 2023
* Revert "feat(native): add expo compatibility for android (#56)"

This reverts commit 647489a.

* apply change in expo plugin

* add expo example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants