Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compatibility with latest expo versions #76

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

Almouro
Copy link
Member

@Almouro Almouro commented Nov 5, 2022

Unnecessary with expo/expo#17852
Might fix #75 as well

@dcalhoun
Copy link

dcalhoun commented Feb 8, 2023

Leaving a friendly note that manually applying these changes to my local node_modules/react-native-flipper-performance-monitor did fix the error below, which is referenced in #75.

java.lang.NullPointerException: Attempt to invoke virtual method 'com.facebook.react.bridge.NativeModule com.facebook.react.bridge.ReactContext.getNativeModule(java.lang.Class)' on a null object reference

@Almouro Almouro changed the title fix: revert now unnecessary hack fix: fix compatibility with latest expo versions Mar 13, 2023
@Almouro Almouro merged commit d697c08 into master Mar 13, 2023
@Almouro Almouro deleted the revert-expo-hack branch March 13, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android benchmark crashes, works fine on iOS
3 participants