Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Swift 5 #216

Closed
wants to merge 5 commits into from
Closed

update Swift 5 #216

wants to merge 5 commits into from

Conversation

Gareth-swifter
Copy link

I have updated project swift version to 5.0 from 3.0 on Xcode 10.2

When I tested project with Xcode 10.2 with iPhone XR 12.2 Simulator on test failured.

Failure Detailes.
Failured Location : Viewtests - testEmbedInNavigationController L144
Failured Test Code : XCTAssertEqual(spreadsheetView.adjustedContentInset.bottom, 0)
Result : XCTAssertEqual failed: ("34.0") is not equal to ("0.0") -

so, i changed the code with
Code: XCTAssertEqual(spreadsheetView.adjustedContentInset.bottom, viewController.view.safeAreaInsets.bottom)

all test passed on Xcode 10.2 with iPhone 7 (iOS 12.2) and iPhone Xr.

@ChristianSteffens
Copy link

Any news on this PR?

@hlongvu
Copy link

hlongvu commented May 2, 2019

Any update on this pr?

@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #216 into master will increase coverage by 4.04%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   77.95%   81.99%   +4.04%     
==========================================
  Files          23       23              
  Lines        1778     1144     -634     
==========================================
- Hits         1386      938     -448     
+ Misses        392      206     -186
Impacted Files Coverage Δ
...k/Sources/SpreadsheetView+CirclularScrolling.swift 100% <ø> (+23.18%) ⬆️
Framework/Sources/Cell.swift 82.35% <ø> (+1.96%) ⬆️
Framework/Sources/Gridlines.swift 50% <ø> (+20%) ⬆️
...work/Sources/SpreadsheetView+UIViewHierarchy.swift 0% <0%> (ø) ⬆️
Framework/Sources/SpreadsheetView.swift 91.35% <100%> (+5.48%) ⬆️
Framework/Sources/IndexPath+Column.swift 100% <100%> (ø) ⬆️
Framework/Sources/Location.swift 100% <100%> (ø) ⬆️
Framework/Sources/Address.swift 100% <100%> (ø) ⬆️
Framework/Sources/CellRange.swift 84.61% <100%> (-0.57%) ⬇️
Framework/Sources/CircularScrolling.swift 95.13% <100%> (+1.34%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6337ce9...b960267. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #216 into master will increase coverage by 4.04%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   77.95%   81.99%   +4.04%     
==========================================
  Files          23       23              
  Lines        1778     1144     -634     
==========================================
- Hits         1386      938     -448     
+ Misses        392      206     -186
Impacted Files Coverage Δ
...k/Sources/SpreadsheetView+CirclularScrolling.swift 100% <ø> (+23.18%) ⬆️
Framework/Sources/Cell.swift 82.35% <ø> (+1.96%) ⬆️
Framework/Sources/Gridlines.swift 50% <ø> (+20%) ⬆️
...work/Sources/SpreadsheetView+UIViewHierarchy.swift 0% <0%> (ø) ⬆️
Framework/Sources/SpreadsheetView.swift 91.35% <100%> (+5.48%) ⬆️
Framework/Sources/IndexPath+Column.swift 100% <100%> (ø) ⬆️
Framework/Sources/Location.swift 100% <100%> (ø) ⬆️
Framework/Sources/Address.swift 100% <100%> (ø) ⬆️
Framework/Sources/CellRange.swift 84.61% <100%> (-0.57%) ⬇️
Framework/Sources/CircularScrolling.swift 95.13% <100%> (+1.34%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6337ce9...b960267. Read the comment docs.

@dillan
Copy link

dillan commented Jun 28, 2019

@kishikawakatsumi How can we help push this forward? Thanks @Widehuang!

@bannzai
Copy link
Owner

bannzai commented Oct 8, 2020

Done about up swift version to 5. I will release it. I close this PR. Thank you your contributions 👍

#256

@bannzai bannzai closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants