-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Swift 5 #216
update Swift 5 #216
Conversation
Any news on this PR? |
Any update on this pr? |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 77.95% 81.99% +4.04%
==========================================
Files 23 23
Lines 1778 1144 -634
==========================================
- Hits 1386 938 -448
+ Misses 392 206 -186
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 77.95% 81.99% +4.04%
==========================================
Files 23 23
Lines 1778 1144 -634
==========================================
- Hits 1386 938 -448
+ Misses 392 206 -186
Continue to review full report at Codecov.
|
@kishikawakatsumi How can we help push this forward? Thanks @Widehuang! |
Done about up swift version to 5. I will release it. I close this PR. Thank you your contributions 👍 |
I have updated project swift version to 5.0 from 3.0 on Xcode 10.2
When I tested project with Xcode 10.2 with iPhone XR 12.2 Simulator on test failured.
Failure Detailes.
Failured Location : Viewtests - testEmbedInNavigationController L144
Failured Test Code : XCTAssertEqual(spreadsheetView.adjustedContentInset.bottom, 0)
Result : XCTAssertEqual failed: ("34.0") is not equal to ("0.0") -
so, i changed the code with
Code: XCTAssertEqual(spreadsheetView.adjustedContentInset.bottom, viewController.view.safeAreaInsets.bottom)
all test passed on Xcode 10.2 with iPhone 7 (iOS 12.2) and iPhone Xr.