Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate swift version to 5 #256

Merged
merged 46 commits into from
Oct 8, 2020
Merged

Migrate swift version to 5 #256

merged 46 commits into from
Oct 8, 2020

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Oct 7, 2020

What

  • Migrate swift version to 5.
  • Remove all warnings for migrated to swift 5.
  • Fix erorr travis CI error

Links

continue of https://github.com/kishikawakatsumi/SpreadsheetView/pull/254

reference:continue of #255

xcodebuilds
end

def xcodebuilds_for_long_time_testing
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got The job exceeded the maximum time limit for jobs, and has been terminated for device has big_screen(e.g iPad, iPhone 11 Pro max) tests. So, this method that escaping limitation for long time teting

- stage: carthage
osx_image: xcode12
script:
<%-# Xcode 12 workarround. see: https://github.com/Carthage/Carthage/issues/3019#issuecomment-665136323 -%>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcode 12 and carthage are has problem about it can't building with carthage command. I found workarround and write it. reference: Carthage/Carthage#3019 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant