-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepared Cadence chart release 0.22.0 with server 0.22.3 #1299
Conversation
@longquanzheng could you please take a look at the charts when you have the time to double check? With emphasis on:
We couldn't test the Cassandra changes, but for eyeballing they should be fine if I hadn't messed anything up. (I unfortunately I cannot add you as an external reviewer, so this was my second idea to give you a chance for catching my mistakes in the chart.) |
Thanks @pregnor for updating it. It looks good to me. |
While we can certainly hide breaking config changes from users, I'm not sure it's a good idea in the long-term, because it will inevitably lead to confusion (you can configure nosql under cassandra?). I guess it's fine for now, but we should just rip the bandaid off. @longquanzheng do you have any backward compatibility promise for configuration? |
Everything is backward compatible -- including the nosql.PluginName. So even we don't do anything in the template for this PR, upgrading to 0.22 should also work. Right now the convention is that we always keep backward compatibility. We already got a bunch of config changes that we wanted to get rid of:
All those are in compatibility mode today. My thought is that in a major release, Cadence will make it required. cc @meiliang86 @demirkayaender @Shaddoll @vytautas-karpavicius @yycptt @emrahs LMK if you have a different idea about when we should do the breaking change on loading config. |
Oh, okay. I thought this was a breaking change. Breaking changes are okay in major versions, but that's usually harder in applications. Not even sure it makes sense for you to follow semver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pregnor
Great work on this @pregnor, would it be possible to merge this PR any time soon? Looks like that there's a pending reviewer left and some conflicts between branches. Thanks! |
Hi @mikejoh , Yes we were planning to do the merge and chart version release today. |
9879cca
to
ed8decd
Compare
What's in this PR?
Prepared Cadence chart 0.22.0 with server 0.22.3.
persistence
maxQPS
, configuration was dropped from Cadence server in the past.protoversion
configuration andCASSANDRA_PROTOCOL_VERSION
environment variable.Why?
To fully support the latest Cadence minor version 0.22 (0.22.0, 0.22.1, 0.22.2, 0.22.3).
Additional context
I also checked whether the
is_cron
field or the feature flags would require any chart modification, but as much as I could tell those are internal-only changes to the Cadence server so nothing to change in the chart this time it seems (to be confirmed).Checklist
To Do