Adding protoversion in config file

[iamrodrigo]

What changed?
Continuation of #4252. ProtoVersion is now a config value

Why?
Labeled as Up for grabs as good first issue in #3536. PR was divided in 2 request, first one making sure compatibility was correct, second one adding the actual config values

How did you test it?
Playing with some values in the development.yaml file. Let me know what other ways I can test this

Potential risks
Connection to cassandra might be broken

Release notes
Maybe? Let me know if you want me to do that in the second step

Documentation Changes
Likely to be the case. Let me know if I need to do this in the second step

[longquanzheng]

I believe we only need the changes under docker/ folder. Config changes under config/ is not necessary as they will default to the right version.

[iamrodrigo]

@longquanzheng I'm not really familiar with cassandra but is there a case where someone is not using docker and wants to use a different protoversion? (either 2 or 3). if that's the case, wouldn't the config files the best way to do it? Just trying to understand this better!

[longquanzheng]

Good question. Yes It’s possible but these config files are meant to be minimal for getting up and running for development. The full possible configs are listed in our documentation. https://cadenceworkflow.io/docs/operation-guide/setup/#static-configuration That is a better place otherwise this config here will have to provide every possible values. But it doesn’t have enough information to tell users what they are. also don’t worry about the document for your new config . The new release will have it automatically by godocs

On Fri, Jun 11, 2021 at 9:35 PM Rodrigo Villarreal ***@***.***> wrote: @longquanzheng <https://github.com/longquanzheng> I'm not really familiar with cassandra but is there a case where someone is not using docker and wants to use a different protoversion? (either 2 or 3). if that's the case, wouldn't the config files the best way to do it? Just trying to understand this better! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCQPM4WGGRAEZTCNRALP2LTSLP2FANCNFSM46MHBVLA> .

-- Thanks, Quanzheng

[iamrodrigo]

@longquanzheng friendly reminder to check this :)

[coveralls]

Pull Request Test Coverage Report for Build 913da920-7f17-43ba-93ba-061042fff29a

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 48 unchanged lines in 10 files lost coverage.
• Overall coverage increased (+0.006%) to 60.166%

---

Files with Coverage Reduction	New Missed Lines	%
host/archivalTest.go	1	97.81%
service/history/execution/mutable_state_task_refresher.go	1	74.4%
common/persistence/historyManager.go	2	66.33%
common/task/fifoTaskScheduler.go	2	87.63%
common/types/mapper/thrift/shared.go	2	70.54%
service/history/queue/timer_queue_processor.go	2	58.77%
service/history/shard/context.go	2	65.84%
service/matching/matcher.go	2	91.46%
common/persistence/cassandra/cassandraPersistence.go	3	51.94%
common/persistence/cassandra/cassandraPersistenceUtil.go	31	84.92%

Totals
Change from base Build c492a118-34d9-4250-80d7-448c55b87f83:	0.006%
Covered Lines:	89915
Relevant Lines:	149444

---

💛 - Coveralls