Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in docker config template which cause docker image corruption #4310

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Fix typo in docker config template which cause docker image corruption #4310

merged 2 commits into from
Jul 10, 2021

Conversation

longquanzheng
Copy link
Collaborator

@longquanzheng longquanzheng commented Jul 10, 2021 •
edited
Loading

What changed?

Why?
For uber-go/cadence-client#1111

The bug is introduced in #4263

How did you test it?

Potential risks

Release notes

Documentation Changes

@longquanzheng longquanzheng requested a review from Groxx July 10, 2021 00:32
This was referenced Jul 10, 2021
Merged
Open
yycptt
yycptt reviewed Jul 10, 2021
View reviewed changes
docker/config_template.yaml Outdated
@@ -20,15 +20,15 @@ persistence:
keyspace: {{ default .Env.KEYSPACE "cadence" }}
user: {{ default .Env.CASSANDRA_USER "" }}
password: {{ default .Env.CASSANDRA_PASSWORD "" }}
protocolVersion: {{ default .Env.CASSANDRA_PROTOCOL_VERSION "4" }}
protoVersion: {{ default .Env.CASSANDRA_PROTOCOL_VERSION "4" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update the env variable name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for sure. Updated.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 00ed7346-1ea3-4a89-ba22-39bdfc28feb8

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 90 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.005%) to 56.648%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cassandra/main.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
common/membership/rpServiceResolver.go 2 73.58%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/cache/lru.go 3 90.73%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 50.23%
common/persistence/statsComputer.go 3 95.36%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 59.6%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 11 77.83%
Totals Coverage Status
Change from base Build c8778065-a47d-46f0-b1d5-48548313e562: 0.005%
Covered Lines: 77400
Relevant Lines: 136633
💛 - Coveralls

@longquanzheng longquanzheng merged commit a1b9679 into master Jul 10, 2021
@longquanzheng longquanzheng deleted the qlong-fix-config-docker branch July 10, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longquanzheng @coveralls @yycptt