Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cp up --provider kind kube-proxy issue on MacOS #353

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented Oct 18, 2021

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Fixed cp up --provider kind kube-proxy issue on MacOS which caused the kube-proxy to CrashLoopBackoff with open /proc/sys/net/netfilter/nf_conntrack_max: permission denied.

Why?

kubernetes-sigs/kind#2240

I added a post-kind-create-clusters step to fix the issue for MacOS context where a ConfigMap change is enough.

Additional context

Kind v0.11.1 is going to fix this issue, but upgrading breaks bank-vaults token issuer handling which is fixed in bank-vaults v1.13.1, but upgrading bank-vaults in Pipeline is a bigger effort so it is postponed.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

kubernetes-sigs/kind#2240

Kind v0.11.1 is going to fix this issue, but
upgrading breaks the bank-vaults which takes a lot
to upgrade to postponed.

Instead I added a post-kind-create-clusters step
to fix the issue for macOS context where a
ConfigMap change is enough.
@pregnor pregnor added the bug Something isn't working label Oct 18, 2021
@pregnor pregnor requested a review from akijakya October 18, 2021 13:38
@pregnor pregnor self-assigned this Oct 18, 2021
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@pregnor pregnor merged commit 22e27da into master Oct 20, 2021
@pregnor pregnor deleted the fix/kind-old-version-issue branch October 20, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants