Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fixKind0_9_0KubeProxy method on linux systems #371

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Aug 9, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Run fixKind0_9_0KubeProxy method on linux systems as well.

Why?

Similar to the issue solved by this previous PR, the same fix is also needed on linux.

Additional context

Tested on ubuntu-latest Github Actions runner.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@akijakya akijakya requested a review from pregnor August 9, 2022 15:31
@akijakya akijakya self-assigned this Aug 9, 2022
@akijakya akijakya changed the title Updated kind version Run fixKind0_9_0KubeProxy method on linux systems Aug 9, 2022
@akijakya akijakya changed the title Run fixKind0_9_0KubeProxy method on linux systems Run fixKind0_9_0KubeProxy method on linux systems Aug 9, 2022
- because it has at least 3 occurrences in the package and the linter wanted to
@akijakya akijakya changed the title Run fixKind0_9_0KubeProxy method on linux systems Run fixKind0_9_0KubeProxy method on linux systems Aug 9, 2022
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I get it entirely, but if you tested and works, it is fine.

@akijakya akijakya merged commit 134b30f into master Aug 10, 2022
@akijakya akijakya deleted the upgrade-kind-version branch August 10, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants