-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add liveness and readiness probes to koperator's manager pod #1050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, there was one misplaced import line and a couple questions.
…e length limitations
…e length limitations
…at_liveness_readiness
…at_liveness_readiness
I did some investigation around the readiness and liveness probes, specifically on the implementation side, so within the manager. I did not know, when the controller will report readyz for the first time. Luckily, the kubebuilder did a good work here I think. The HTTP endpoints registration will happen in On the other hand the liveness probe may not do what you think. The healthyz probe is registered this way: I have found the original request: Support health and liveness probes #297 and the correspoding PR: added health probes Do you know what happens when the |
Thank you for the detailed investigation @szykes! :)) |
Description
Implementation of readiness and liveness probe of koperators' manager pod. Referring to #661.
Type of Change
Checklist