Support health and liveness probes

[j-vizcaino]

I'm adding a liveness probe to a manager built with controller-runtime.
The manager already leverages the HTTP service provided natively to serve Prometheus metrics.

I would like to add another endpoint /live to provide the liveness of the application, on the same HTTP server that is used for metrics.
There does not seem to be a way to do this today because the http mux is created internally and attached to the HTTP server.

A way to circumvent this is to basically copy/paste the http server logic into a package of my own and add the extra handler but it feels sad that there is no way to reuse the existing code.

[DirectXMan12]

we should have a general liveness hook. I'm not sure we want to make this a general HTTP serving platform, but liveness support would definitely be useful.

/kind feature
/priority important-longterm

[j-vizcaino]

Agreed, having a standard way for serving a liveness hook would be nice.
At the very least, it would be useful to be able to provide the HTTP server somehow as that would let the user tweak and reuse that component elsewhere.

[DirectXMan12]

/good-first-issue

[k8s-ci-robot]

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[GrigoriyMikhalkin]

Hi, i would like to try to implement this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[DirectXMan12]

/lifecycle frozen

[estroz]

@DirectXMan12 has this been fully implemented in #419 or is there more to do?

[DirectXMan12]

I think it's fully implemented