-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add healthz check to agent #903
add healthz check to agent #903
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhongjun.li <zhongjun.li@daocloud.io>
5455e82
to
99f90a7
Compare
/retest |
@learner0810: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sorry, I missed this PR. Please cc me to trigger the test or by another push. |
Hi @learner0810 |
My pr is to solve this problem kubernetes-sigs/controller-runtime#297. If the agent needs to add a health check, then it needs to bind a port. does karmada have a port plan? |
I wonder how to use the |
There is no way to confirm, if the agent pod does not add HealthzCheck, then this pr is not necessary and I will close this pr |
I haven't looked into the code.
What's this used for? What's the benefit? Can you give a simple description? |
@Garrybest Do you think this is needed for |
I suppose this check is duplicated, see karmada/vendor/sigs.k8s.io/controller-runtime/pkg/healthz/healthz.go Lines 68 to 72 in b4be8be
|
Good to know. Yeah, I agree. So, let's close it. @learner0810 Thanks for doing this all the same. /close |
@RainbowMango: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: