Rails 6 zeitwerk support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiob
added a commit
to claudiob/google_sign_in
that referenced
this pull request
Aug 6, 2020
Commit 70ad363 bumped the version of the gem to 1.2.0 without running "bundle" to also update the version in Gemfile.lock. Tests have been failing on Travis CI since because of this, see https://travis-ci.org/github/basecamp/google_sign_in/jobs/690398898 > You are trying to install in deployment mode after changing > your Gemfile. Run `bundle install` elsewhere and add the > updated Gemfile.lock to version control. --- Starting from basecamp#44 this library depends on Rails 6 which requires Ruby 2.5.0 or newer. For that reason, older versions of Ruby have been removed from the Travis CI configuration, as they would inherently fail, see: https://guides.rubyonrails.org/v6.0/upgrading_ruby_on_rails.html#ruby-versions
georgeclaghorn
pushed a commit
that referenced
this pull request
Sep 1, 2020
Commit 70ad363 bumped the version of the gem to 1.2.0 without running "bundle" to also update the version in Gemfile.lock. Tests have been failing on Travis CI since because of this, see https://travis-ci.org/github/basecamp/google_sign_in/jobs/690398898 > You are trying to install in deployment mode after changing > your Gemfile. Run `bundle install` elsewhere and add the > updated Gemfile.lock to version control. --- Starting from #44 this library depends on Rails 6 which requires Ruby 2.5.0 or newer. For that reason, older versions of Ruby have been removed from the Travis CI configuration, as they would inherently fail, see: https://guides.rubyonrails.org/v6.0/upgrading_ruby_on_rails.html#ruby-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this will help someone else get the gem working with Rails 6.