Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make test suite pass on Travis CI #53

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

claudiob
Copy link
Contributor

@claudiob claudiob commented Aug 6, 2020

Commit 70ad363 bumped the version of the gem to 1.2.0 without running "bundle" to also update the version in Gemfile.lock.

Tests have been failing on Travis CI since because of this:

You are trying to install in deployment mode after changing
your Gemfile. Run bundle install elsewhere and add the
updated Gemfile.lock to version control.

Morever, starting from #44 this library depends on Rails 6 which requires Ruby 2.5.0 or newer.
For that reason, older versions of Ruby have been removed from the Travis CI configuration, as they would inherently fail.

@claudiob claudiob marked this pull request as draft August 6, 2020 20:37
Commit 70ad363 bumped the version of the gem to 1.2.0 without
running "bundle" to also update the version in Gemfile.lock.

Tests have been failing on Travis CI since because of this, see
https://travis-ci.org/github/basecamp/google_sign_in/jobs/690398898

> You are trying to install in deployment mode after changing
> your Gemfile. Run `bundle install` elsewhere and add the
> updated Gemfile.lock to version control.

---

Starting from basecamp#44 this library depends on Rails 6 which requires Ruby 2.5.0
or newer. For that reason, older versions of Ruby have been removed from
the Travis CI configuration, as they would inherently fail, see:
https://guides.rubyonrails.org/v6.0/upgrading_ruby_on_rails.html#ruby-versions
@claudiob claudiob marked this pull request as ready for review August 6, 2020 20:49
@georgeclaghorn georgeclaghorn merged commit 81e3915 into basecamp:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants