Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better link to release notes #58

Closed
hobofan opened this issue May 4, 2023 · 2 comments · Fixed by #116
Closed

Use a better link to release notes #58

hobofan opened this issue May 4, 2023 · 2 comments · Fixed by #116
Labels
enhancement New feature or request

Comments

@hobofan
Copy link
Member

hobofan commented May 4, 2023

Background / prior discussions: #49, #37 (comment), bazelbuild/bazel-central-registry#357

TLDR: We are using a link based on the assumption that the release tag has the format v{VERSION}, which is true for a big percentage of packages, but not 100% reliable

Ideas and suggestions on how to achieve this are welcome!

@hobofan hobofan added the enhancement New feature or request label May 4, 2023
@hobofan
Copy link
Member Author

hobofan commented Oct 25, 2023

As discussed at BazelCon, it's probably viable to call the Github API from the frontend to at least determine the module version format

@alexeagle
Copy link
Contributor

Yeah the tag column on https://bazel-contrib.github.io/bazel-catalog/ shows the data we want I think, and it requests https://img.shields.io/github/v/tag/seh/rules_kustomize. But I think shields.io has a backend server that talks to github API, not done from the web client.

I'm imagining a really simple solution here: first do #94 to render the latest tag badge, then we can edit the DOM to copy from the node created by the svg response and use that to create the release notes link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants