Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to release notes #49

Closed
wants to merge 1 commit into from
Closed

Fix broken link to release notes #49

wants to merge 1 commit into from

Conversation

hanneskaeufler
Copy link
Contributor

GitHub's urls to the releases are not prefixed with v. All those links in the registry are 404s currently.

GitHub's urls to the releases are not prefixed with `v`.
All those links in the registry are 404s currently.
@hanneskaeufler
Copy link
Contributor Author

GitHub's urls to the releases are not prefixed with v. All those links in the registry are 404s currently.

Ah that's annoying, that ... depends on the tag name. Current link is good for e.g. https://github.com/aspect-build/bazel-lib/releases/tag/v1.19.2

Not sure what to do about this then ... I don't suppose we have any information on the git tag name.

@alexeagle
Copy link
Contributor

Yeah, see #37 (comment) for more discussion of this.
One "right" answer is to add more to the upstream metadata.json provided by ruleset in the BCR saying what their tagging scheme is.

@hanneskaeufler hanneskaeufler deleted the hk-fix-broken-release-notes-link branch February 26, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants