Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix private functions/variables in def.bzl with _ #3

Closed
kchodorow opened this issue Mar 17, 2016 · 0 comments
Closed

Prefix private functions/variables in def.bzl with _ #3

kchodorow opened this issue Mar 17, 2016 · 0 comments

Comments

@kchodorow
Copy link
Contributor

Right now, many of the implementations, the attrs, and output are public.
@jmhodges jmhodges mentioned this issue Sep 6, 2017
Closed
groodt pushed a commit to groodt/rules_go that referenced this issue Mar 14, 2022
@sparkprime
Merge pull request bazel-contrib#3 from jbeda/readme-fix
2282fdf 
Fix up repo paths in the README.
@JamesMBartlett JamesMBartlett mentioned this issue Jun 21, 2022
Closed
@renovate renovate bot mentioned this issue Nov 20, 2023
Open
1 task
fmeum added a commit that referenced this issue Jun 24, 2024
@fmeum
Fix test #3
ca24e23
fmeum added a commit that referenced this issue Jun 24, 2024
@fmeum
Fix test #3
2d9ed97
fmeum added a commit that referenced this issue Jul 1, 2024
@fmeum
Fix test #3
3a2da19
fmeum added a commit that referenced this issue Jul 7, 2024
@fmeum
Fix test #3
8eb58c0
fmeum added a commit that referenced this issue Jul 10, 2024
@fmeum
Add a full fs.FS implementation to runfiles (#3969)
3e84965 
* WIP: Add a full `fs.FS` implementation to `runfiles`

* Extract out common implementation

* Minimal feature parity for manifest implementation

* Implement manifest except for dir statting plus test

* Test info

* Add basic trie implementation

* Fully fix test

* Simplify

* Vendor testfs

* FIx tests

* Cleanup

* Simplify

* Root symlinks

* Simplify further

* Add comments and refactor

* Adopt test to Bzlmod

* Also materialize canonical names

* Adjust comment

* Attempt to throw test failures

* Attemp to fix WIndows #2

* Fix test #3

* Address review comments

* Fix test

* Address review comments

* Rename links for better test coverage

* Rename manifest dir entries

* Add `String()` implementations and faithfully fake runfiles dir

* Resolve one layer of symlinks in directory impl

* Resolve all symlinks
@renovate renovate bot mentioned this issue Aug 28, 2024
Open
1 task
@renovate renovate bot mentioned this issue Dec 16, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kchodorow @pmbethe09