Fix import path #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: any opinions on who should own the go rules? |
|
LGTM |
groodt
pushed a commit
to groodt/rules_go
that referenced
this pull request
Mar 14, 2022
Add copyright notice to all files.
fmeum
added a commit
that referenced
this pull request
Jun 24, 2024
fmeum
added a commit
that referenced
this pull request
Jul 10, 2024
* WIP: Add a full `fs.FS` implementation to `runfiles` * Extract out common implementation * Minimal feature parity for manifest implementation * Implement manifest except for dir statting plus test * Test info * Add basic trie implementation * Fully fix test * Simplify * Vendor testfs * FIx tests * Cleanup * Simplify * Root symlinks * Simplify further * Add comments and refactor * Adopt test to Bzlmod * Also materialize canonical names * Adjust comment * Attempt to throw test failures * Attemp to fix WIndows #2 * Fix test #3 * Address review comments * Fix test * Address review comments * Rename links for better test coverage * Rename manifest dir entries * Add `String()` implementations and faithfully fake runfiles dir * Resolve one layer of symlinks in directory impl * Resolve all symlinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI, see http://ci.bazel.io/job/rules_go/1/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/console.