Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more rules in Gazel #59

Merged
merged 4 commits into from
Aug 18, 2016
Merged

Support more rules in Gazel #59

merged 4 commits into from
Aug 18, 2016

Conversation

yugui
Copy link
Contributor

@yugui yugui commented Aug 3, 2016

@yugui yugui force-pushed the feature/gazel_2 branch from 2682c11 to eef9965 Compare August 3, 2016 12:49
@yugui yugui force-pushed the feature/gazel_1 branch from 719de74 to b8064d6 Compare August 8, 2016 10:49
@yugui yugui force-pushed the feature/gazel_2 branch from eef9965 to 7241aa5 Compare August 8, 2016 10:56
@yugui yugui force-pushed the feature/gazel_1 branch 4 times, most recently from 4f278bc to abcd353 Compare August 17, 2016 04:49
@yugui yugui changed the base branch from feature/gazel_1 to master August 17, 2016 06:25
@yugui
Copy link
Contributor Author

yugui commented Aug 17, 2016

@pmbethe09 Could you take a look at this PR?

@pmbethe09
Copy link
Contributor

LGTM

@yugui yugui merged commit ae8ea32 into master Aug 18, 2016
@yugui yugui deleted the feature/gazel_2 branch August 18, 2016 02:12
groodt pushed a commit to groodt/rules_go that referenced this pull request Mar 14, 2022
…b#59)

* Location, error formatting and stack trace improvements

* Static context for AST nodes
* Thunks no longer need `name`
* Prototype for showing snippets in error messages (old format still
available)
* Use ast.Function to represent methods and local function sugar.
* Change tests so that the error output is pretty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants