Make output modes configurable #60
Conversation
yugui
commented
Aug 3, 2016
•
yugui
commented
- Extracted from Import Gazel, BUILD file generator #51
- Depends on Import minimal version of gazelle, a BUILD file generator #57, Support dependencies to go_library rules in the same repository #58 and Support more rules in Gazel #59
- c.f. Create "glaze" BUILD file generator for Go #15
yugui
force-pushed
the
feature/gazel_2
branch
3 times, most recently
from
6907367 to
7ae0cfe
Compare
| if err != nil { | ||
| return err | ||
| } | ||
| defer os.Remove(f.Name()) |
There was a problem hiding this comment.
In my experience, worrying about the error from the defer is overkill, and creates complexity without much gain.
I agree.
Actually in my experience it was necessary to correctly deal with disk full in the target file system, temporary network issue or something. But as you said, worrying about that does not add much value in this specific case of short-living process unlike my experience.
I would have written (instead of line 31-49):
defer os.Remove(f.Name()) defer f.Close() if _, err := f.Write(bzl.Format(file)); err != nil { return err }
Thank you for your suggestion. Fixed.
But I added Sync because Close used to also imply Sync in the original code.
|
@pmbethe09 Could you take another look at this PR? |
| } | ||
| defer os.Remove(f.Name()) | ||
| defer f.Close() | ||
| if _, err = f.Write(bzl.Format(file)); err != nil { |
There was a problem hiding this comment.
use := instead of = whenever possible, like here.
|
LGTM with a couple of nitpicks. |
Added "fix" and "diff" modes
|
Thank you for your review. |
