Replace uses of JavaInfo.transitive_export with custom label collection. #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
approved these changes
May 12, 2021
illicitonion
added a commit
to illicitonion/rules_jvm_external
that referenced
this pull request
May 24, 2021
bazel-contrib#557 replaced using `JavaInfo.transitive_exports` by instead using `HasMavenDeps.transitive_exports` but it changed how this was computed. The JavaInfo traversal code: https://github.com/bazelbuild/bazel/blob/5a647bb234ba9817f51fdb2b4b5973a0602f51a4/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java#L341-L357 only follows the `exports` attribute, and merges together each of the transitive exports it finds that way. The replacement starlark code was traversing each of `deps`, `exports`, and `runtime_deps`, looking for anything which may have been exported _to_ those targets, which exports significantly more targets. This adds a unit test to prevent future regressions.
shs96c
pushed a commit
that referenced
this pull request
Jul 7, 2021
#557 replaced using `JavaInfo.transitive_exports` by instead using `HasMavenDeps.transitive_exports` but it changed how this was computed. The JavaInfo traversal code: https://github.com/bazelbuild/bazel/blob/5a647bb234ba9817f51fdb2b4b5973a0602f51a4/src/main/java/com/google/devtools/build/lib/rules/java/JavaCommon.java#L341-L357 only follows the `exports` attribute, and merges together each of the transitive exports it finds that way. The replacement starlark code was traversing each of `deps`, `exports`, and `runtime_deps`, looking for anything which may have been exported _to_ those targets, which exports significantly more targets. This adds a unit test to prevent future regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify
JavaInfoprovider, we're removingtransitive_exportsfrom it (and the nativeTransitiveExportsProvider).rules_jvm_externalis the only downstream project, that this change breaks.This PR works with both older and newer versions of Bazel.
Collecting exported labels in an aspect is a better option, because it work also over other Java-like targets (Kotlin, Android) which have JavaInfo provider.
transitive_exportsalso creates problems when definingJavaInfo()andjava_common.compileAPI (because Labels would need to be passed in).Issue: bazelbuild/bazel#13457
Design document: https://docs.google.com/document/d/10isTEK5W9iCPp4BIyGBrLY5iti3Waaam6EeGVSjq3r8/edit#bookmark=id.34gjanvu5611