Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip incompatible_enable_exports_provider #13457

Closed
comius opened this issue May 10, 2021 · 4 comments
Closed

Flip incompatible_enable_exports_provider #13457

comius opened this issue May 10, 2021 · 4 comments
Assignees
@comius
Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules

Comments

@comius
Copy link
Contributor

comius commented May 10, 2021 •
edited
Loading

Flag: --incompatible_enable_exports_provider
Available since: 2021-05-10
Flipped to false in: Bazel 5.0.0

Removes JavaInfo.transitive_exports.

Migration

Collect export labels using an aspect.
@comius comius added team-Rules-Java Issues for Java rules incompatible-change Incompatible/breaking change labels May 10, 2021
@comius comius self-assigned this May 10, 2021
@comius comius mentioned this issue May 10, 2021
Merged
bazel-io pushed a commit that referenced this issue May 11, 2021
@comius @copybara-github
Disable JavaInfo.transitive_export field and propagation of Transitiv…
7800ff9 
…eExports provider.

RELNOTES[inc]: --incompatible_enable_exports_provider is flipped to false. See #13457 for details.

PiperOrigin-RevId: 373100553
@comius comius added the P2 We'll consider working on this in future. (Assignee optional) label Jul 29, 2021
@martis42
Copy link

This is labeled with breaking-change-5.0, which I interpret as the intention to flip this with Bazel 5.0.0.
The flag is however still inactive by default:
https://github.com/bazelbuild/bazel/blob/5.0.0/src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java#L151

Please update the issue status.

@comius
Copy link
Contributor Author

comius commented Feb 24, 2022

This is labeled with breaking-change-5.0, which I interpret as the intention to flip this with Bazel 5.0.0. The flag is however still inactive by default: https://github.com/bazelbuild/bazel/blob/5.0.0/src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java#L151

Please update the issue status.

The flipped state is "false". During the flag review, there were comments to name it without using negation, i.e. using disable in the name.

@meteorcloudy
Copy link
Member

Should we close this issue if the incompatible change is already enabled by default?

@comius
Copy link
Contributor Author

comius commented Feb 24, 2022

And removed. Closing it.

@comius comius closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comius comius

Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@comius @meteorcloudy @martis42