refactor: remove packages/angular #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
alan-agius4,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
rm_angular_builder
branch
from
2613ea3 to
25108d0
Compare
It is moving to just-jeb/angular-builders#1048 We announced the deprecation in the README of this package for 4.x
alexeagle
force-pushed
the
rm_angular_builder
branch
from
25108d0 to
7da12e4
Compare
|
Should we add a link to that project? Or just as part of the 5.0 changelog? |
|
@jbedard where are you suggesting that link would go? it's already on https://www.npmjs.com/package/@bazel/angular in the README for anyone prior to the next release to see |
|
I guess I was thinking in the changelog? Although I don't see any other reference to this project in the changelog so 🤷 |
|
Looking for an approve from you so I can merge Will def be in the 5.0 release notes |
jbedard
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is moving to just-jeb/angular-builders#1048
We announced the deprecation in the README of this package for 4.x