-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @bazel/angular package #1048
Conversation
This provides a very small shim builder, which spawns the Bazel build tool under an ng build or ng test command. It can be useful during a migration, where developers use Angular CLI but some parts of the workspace build and test with Bazel. It is moving from https://github.com/bazelbuild/rules_nodejs/tree/stable/packages/angular because that project is cutting scope. Fixes #1047
@just-jeb could you help fit this new code into your lerna model for build and release? @alan-agius4 can probably help upgrade it to Angular 12 so it is version-aligned with the other builders in here |
It is moving to just-jeb/angular-builders#1048 We announced the deprecation in the README of this package for 4.x
It is moving to just-jeb/angular-builders#1048 We announced the deprecation in the README of this package for 4.x
Hey @alexeagle, I'll do the upgrade, no problem. |
Also, can I have write access to the repo so that I could push to this PR please? |
Sure, I invited you to that repo with write access. I'm surprised my usual GitHub settings for "Allow edits by project maintainers" didn't apply here to give you push access to that branch automatically. Nope no open issues for this code, and also no automated tests. It's a very simple bit of glue, which hasn't changed since we added it. Also, since it doesn't have any conditional logic, it's not very unit-testable. I could imagine an integration test if that's important to you. |
Well I was thinking about a simple Angular app (even the auto generated one) with Bazel config that uses this builder, just to have a regression test and make sure I'm not breaking anything. |
Here's an old example that uses this builder Note that to test this, there's no need to even have an angular app. We just want to run |
Test with npx @angular/cli build in the packages/bazel/example folder
I added a commit with a bit of bare files. Didn't try adding a package.json in there yet - I'm not sure how much fixture is required to make your monorepo e2e test runner work here. |
Thanks @just-jeb for accepting to add this in your repo and thanks @alexeagle for porting this. If anyone needs helps feel free to reach out 😁 |
It is moving to just-jeb/angular-builders#1048 We announced the deprecation in the README of this package for 4.x
It is moving to just-jeb/angular-builders#1048 We announced the deprecation in the README of this package for 4.x
@all-contributors please add @alexeagle for code. |
I've put up a pull request to add @alexeagle! 🎉 |
@all-contributors please add @alan-agius4 for code. |
I've put up a pull request to add @alan-agius4! 🎉 |
@Mawi137 Hey, I'm sorry, how is that related to |
Ah sorry, must have thought that this was the Angular 13 issue 😅 |
This provides a very small shim builder, which spawns the Bazel build tool under an ng build or ng test command.
It can be useful during a migration, where developers use Angular CLI but some parts of the workspace build and test with Bazel.
It is moving from https://github.com/bazelbuild/rules_nodejs/tree/stable/packages/angular
because that project is cutting scope.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Feature
What is the current behavior?
Issue Number: #1047
What is the new behavior?
See added README
Does this PR introduce a breaking change?
No
Other information