Drop curl fallback for oci_pull #562
Comments
ddeville
added a commit
to ddeville/rules_oci
that referenced
this issue
May 29, 2024
Rather than falling back to curl let's actually pass the headers to the native Bazel downloader if we're running a version of Bazel that supports them (i.e. >= 7.1.0). I had to bring the `bazel_features` repo to detect this. Note that I've kept support for curl rather than introducing the breaking change (as bazel-contrib#562 discusses) so that we can start taking advantage of it without breaking for people still on older versions of Bazel.
ddeville
added a commit
to ddeville/rules_oci
that referenced
this issue
May 29, 2024
Rather than falling back to curl let's actually pass the headers to the native Bazel downloader if we're running a version of Bazel that supports them (i.e. >= 7.1.0). I had to bring the `bazel_features` repo to detect this. Note that I've kept support for curl rather than introducing the breaking change (as bazel-contrib#562 discusses) so that we can start taking advantage of it without breaking for people still on older versions of Bazel.
|
fixed by #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we implemented oci_pull we created a fallback to curl behavior due to a missing feature in Bazel bazelbuild/bazel#19501, now that Bazel supports
headersfeature, we no longer need this fallback and we should remove it as a breaking change in 2.x and encourage people to upgrade Bazel.The text was updated successfully, but these errors were encountered: