Support passing headers to download if Bazel supports it #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than falling back to curl let's actually pass the headers to the native Bazel downloader if we're running a version of Bazel that supports them (i.e. >= 7.1.0). I had to bring the `bazel_features` repo to detect this. Note that I've kept support for curl rather than introducing the breaking change (as bazel-contrib#562 discusses) so that we can start taking advantage of it without breaking for people still on older versions of Bazel.
|
This is already landed on 2.x via #528 See https://github.com/bazel-contrib/rules_oci/blob/2.x/oci/private/pull.bzl |
|
ah oops I didn't realize there was a 2.x branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than falling back to curl let's actually pass the headers to the native Bazel downloader if we're running a version of Bazel that supports them (i.e. >= 7.1.0). I had to bring the
bazel_featuresrepo to detect this.Note that I've kept support for curl rather than introducing the breaking change (as #562 discusses) so that we can start taking advantage of it without breaking for people still on older versions of Bazel.